Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various layout cleanup. #6650

Merged
merged 6 commits into from Jul 18, 2015
Merged

Various layout cleanup. #6650

merged 6 commits into from Jul 18, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 17, 2015

Review on Reviewable
Ms2ger added 6 commits Jul 17, 2015
@Ms2ger
Move the traversal traits into the traversal module.
3e2c441
@Ms2ger
Scope the allowed unsafe code in traversal.rs.
4b08cea
@Ms2ger
Stop using Option in ThreadSafeLayoutNodeChildrenIterator::parent_node.
c018863
@Ms2ger
Remove unused ThreadSafeLayoutNode::traverse_postorder_mut.
bb444df
@Ms2ger
Use Ref::map to make ThreadSafeLayoutNode::style safe.
46b3624
@Ms2ger
Reduce the amount of code in the unsafe block in ParallelPostorderFlo…
Loading status checks…
5d36fbc 
…wTraversal::run_parallel.
@highfive
Copy link

highfive commented Jul 17, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 17, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5585

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 17, 2015

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 3 of 3 files at r5, 1 of 1 files at r6.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 17, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

📌 Commit 5d36fbc has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

⌛ Testing commit 5d36fbc with merge e8169a8...
bors-servo pushed a commit that referenced this pull request Jul 17, 2015
bors-servo
Auto merge of #6650 - Ms2ger:layout-cleanup, r=larsbergstrom
e8169a8 
Various layout cleanup.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6650)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

💔 Test failed - mac3
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jul 17, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac1, mac2 are reusable. Rebuilding only mac3...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

💔 Test failed - mac3
@jdm
Copy link
Member

jdm commented Jul 17, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

📌 Commit 5d36fbc has been approved by jdm
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jul 17, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

⌛ Testing commit 5d36fbc with merge e6538c0...
bors-servo pushed a commit that referenced this pull request Jul 17, 2015
bors-servo
Auto merge of #6650 - Ms2ger:layout-cleanup, r=jdm
Loading status checks…
e6538c0 
Various layout cleanup.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6650)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented Jul 17, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2015

⚡ Previous build results for android, gonk, linux1, linux3, mac1, mac2, mac3 are reusable. Rebuilding only linux2...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 5d36fbc into servo:master Jul 18, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:layout-cleanup branch Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @hoppipolla-critic-bot @larsbergstrom @bors-servo @jdm
You can’t perform that action at this time.