Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Window.trap() to trigger a breakpoint trap #6675

Merged
merged 1 commit into from Jul 20, 2015
Merged

Implement Window.trap() to trigger a breakpoint trap #6675

merged 1 commit into from Jul 20, 2015

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Jul 20, 2015

Fix #6673

Review on Reviewable
@tetsuharuohzeki
Implement Window.trap() to trigger a breakpoint trap
Loading status checks…
eb47185
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 20, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5606

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 20, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

📌 Commit eb47185 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

⌛ Testing commit eb47185 with merge 20d8c27...
bors-servo pushed a commit that referenced this pull request Jul 20, 2015
bors-servo
Auto merge of #6675 - saneyuki:trap, r=Ms2ger
Loading status checks…
20d8c27 
Implement Window.trap() to trigger a breakpoint trap

Fix #6673

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6675)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

💔 Test failed - mac1
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jul 20, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

⚡ Previous build results for android, gonk, linux1, linux3, mac2, mac3 are reusable. Rebuilding only linux2, mac1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

💔 Test failed - mac1
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jul 20, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac2, mac3 are reusable. Rebuilding only mac1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit eb47185 into servo:master Jul 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:trap branch Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-content/dom S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tetsuharuohzeki @hoppipolla-critic-bot @Ms2ger @bors-servo @jdm
You can’t perform that action at this time.