Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement DOMPoint and DOMPointReadOnly #6683
Conversation
highfive
commented
Jul 21, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
r? @jdm |
|
-S-awaiting-review +S-needs-code-changes Reviewed 6 of 6 files at r1, 40 of 40 files at r2. components/script/dom/dompoint.rs, line 13 [r2] (raw file): components/script/dom/dompoint.rs, line 50 [r2] (raw file): components/script/dom/dompointreadonly.rs, line 13 [r2] (raw file): components/script/dom/dompointreadonly.rs, line 58 [r2] (raw file): components/script/dom/webidls/DOMPoint.webidl, line 13 [r2] (raw file): components/script/dom/webidls/DOMPoint.webidl, line 14 [r2] (raw file): components/script/dom/webidls/DOMPointReadOnly.webidl, line 13 [r2] (raw file): Comments from the review on Reviewable.io |
|
Thanks for the review, I think this addresses all comments. As discussed on IRC, I left out the Review status: 39 of 46 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. components/script/dom/dompoint.rs, line 50 [r2] (raw file): Comments from the review on Reviewable.io |
|
-S-awaiting-review +S-needs-squash Squash all four commits and ping me, please. Reviewed 4 of 4 files at r3, 3 of 3 files at r4. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
|
Implement DOMPoint and DOMPointReadOnly <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6683) <!-- Reviewable:end -->
|
|
|
Passes some but not all WPT tests. One failure is caused by an issue in codegen for the `DOMPointInit` dictionary, the others by outdated tests: Gecko implements an old version of the spec that overloaded the `DOMPoint` constructor to optionally take an object as the first argument, and made `DOMPointReadOnly` non-constructible.
|
@bors-servo r+ |
|
|
Implement DOMPoint and DOMPointReadOnly <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6683) <!-- Reviewable:end -->
tschneidereit commentedJul 21, 2015