Reject websocket protocol requests that don't match https://tools.iet…

[jdm]

…f.org/html/rfc6455#section-4.1 .

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5621

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[jdm]

r? @Ms2ger

[jdm]

There are some more test expectation updates incoming, so hang tight.

[Ms2ger]

-S-awaiting-review +S-needs-code-changes

---

Reviewed 6 of 7 files at r1.
Review status: 6 of 7 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

^{components/script/dom/webidls/WebSocket.webidl, line 7 [r1] (raw file):}
File a followup for the array form

---

^{components/script/dom/websocket.rs, line 109 [r1] (raw file):}
No need to allocate here. as_slice() would work here, or inline it if you want to avoid its instability.

---

^{components/script/dom/websocket.rs, line 121 [r1] (raw file):}
protocols[i+1..].iter(); any()

---

^{components/script/dom/websocket.rs, line 125 [r1] (raw file):}
any()

---

Comments from the review on Reviewable.io

[Ms2ger]

Reviewed 1 of 7 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[Ms2ger]

-S-awaiting-review +S-awaiting-merge

@bors-servo r+

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit d385cb7 has been approved by Ms2ger

[bors-servo]

⌛ Testing commit d385cb7 with merge 6b4f1a4...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3