Implement Range#extractContents

[Ms2ger]

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5623

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[Ms2ger]

-S-awaiting-review +S-needs-code-changes

---

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{components/script/dom/range.rs, line 502 [r1] (raw file):}
Share some code around here.

---

^{components/script/dom/range.rs, line 569 [r1] (raw file):}
Now I'm wondering whether the children of common_ancestor can change in steps 12-16.

---

Comments from the review on Reviewable.io

[dzbarsky]

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{components/script/dom/range.rs, line 502 [r1] (raw file):}
Wasn't sure what you meant here, I shared this section with cloneContents. Which also fixed some test failures, any idea why?

---

^{components/script/dom/range.rs, line 569 [r1] (raw file):}
Maybe? I also tried computing the children right before iterating them but it didn't change the test results.

---

Comments from the review on Reviewable.io

[dzbarsky]

Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{components/script/dom/range.rs, line 502 [r1] (raw file):}
Nevermind, I'm pretty sure I fixed this earlier but forgot to update expectations.

---

Comments from the review on Reviewable.io

[Ms2ger]

-S-awaiting-review +S-needs-squash

lgtm

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[Ms2ger]

@bors-servo r+ force

[bors-servo]

📌 Commit 46bb09f has been approved by Ms2ger

[bors-servo]

⌛ Testing commit 46bb09f with merge e344374...

[bors-servo]

💔 Test failed - linux2

[jdm]

/dom/interfaces.html
--------------------
PASS expected FAIL Range interface: operation extractContents()
PASS expected FAIL Range interface: document.createRange() must inherit property "extractContents" with the proper type (21)
PASS expected FAIL Range interface: detachedRange must inherit property "extractContents" with the proper type (21)

[jdm]

@bors-servo: r+

[bors-servo]

📌 Commit 4f53bef has been approved by jdm

[bors-servo]

☔ The latest upstream changes (presumably #6699) made this pull request unmergeable. Please resolve the merge conflicts.

[dzbarsky]

@bors-servo: r=jdm

[jdm]

@bors-servo: r+

[bors-servo]

📌 Commit f44691c has been approved by jdm

[Ms2ger]

@bors-servo r+

[bors-servo]

📌 Commit f44691c has been approved by Ms2ger

[bors-servo]

⌛ Testing commit f44691c with merge bdf01dd...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3