Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-selectors #6700

Merged
merged 1 commit into from Jul 23, 2015
Merged

Update rust-selectors #6700

merged 1 commit into from Jul 23, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 22, 2015

Update for servo/rust-selectors#37

Review on Reviewable
@highfive
Copy link

highfive commented Jul 22, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 22, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5627

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 22, 2015

@Ms2ger r?
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 22, 2015

-S-awaiting-review +S-awaiting-merge

@bors-servo r+

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

components/layout/css/matching.rs, line 20 [r1] (raw file):
Nit: lose the {}

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Jul 22, 2015

📌 Commit bbb03d3 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2015

⌛ Testing commit bbb03d3 with merge 135baec...
bors-servo pushed a commit that referenced this pull request Jul 23, 2015
bors-servo
Auto merge of #6700 - servo:selectors, r=Ms2ger
135baec 
Update rust-selectors

Update for servo/rust-selectors#37

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2015

💔 Test failed - mac2
@jdm
Copy link
Member

jdm commented Jul 23, 2015 

failures:
    first_child_pseudo_a.html == first_child_pseudo_b.html
    first_of_type_pseudo_a.html == first_of_type_pseudo_b.html
    last_child_pseudo_a.html == last_child_pseudo_b.html
    last_of_type_pseudo_a.html == last_of_type_pseudo_b.html
    nth_child_pseudo_a.html == nth_child_pseudo_b.html
    nth_last_child_pseudo_a.html == nth_last_child_pseudo_b.html
    nth_last_of_type_pseudo_a.html == nth_last_of_type_pseudo_b.html
    nth_of_type_pseudo_a.html == nth_of_type_pseudo_b.html
    only_of_type_pseudo_a.html == only_of_type_pseudo_b.html
@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Jul 23, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 23, 2015

Added a commit. mach test-ref passes locally.
@SimonSapin
Update rust-selectors
Loading status checks…
055a1c5 
Update for servo/rust-selectors#37
@SimonSapin SimonSapin force-pushed the selectors branch from 0b76194 to 055a1c5 Jul 23, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 23, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2015

📌 Commit 055a1c5 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2015

⌛ Testing commit 055a1c5 with merge 5d857c5...
bors-servo pushed a commit that referenced this pull request Jul 23, 2015
bors-servo
Auto merge of #6700 - servo:selectors, r=Ms2ger
Loading status checks…
5d857c5 
Update rust-selectors

Update for servo/rust-selectors#37

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 055a1c5 into master Jul 23, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 23, 2015
Closed
@SimonSapin SimonSapin deleted the selectors branch Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @hoppipolla-critic-bot @Ms2ger @bors-servo @jdm
You can’t perform that action at this time.