Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upscript: Increase our file descriptor limit on Linux. #6707
Merged
Conversation
We've had problems with this before, and I think it's starting to cause problems again.
highfive
commented
Jul 23, 2015
|
|
hoppipolla-critic-bot
commented
Jul 23, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5632 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@bors-servo: r+ I don't have a problem with this - it's also somewhat consistent with what we do in Gecko: |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 23, 2015
script: Increase our file descriptor limit on Linux. We've had problems with this before, and I think it's starting to cause problems again. See PRs #6629 and #6616; my current theory is that this is the problem. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6707) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJul 23, 2015
We've had problems with this before, and I think it's starting to cause
problems again.
See PRs #6629 and #6616; my current theory is that this is the problem.
r? @larsbergstrom