Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upservo: Upgrade `ipc-channel`, and make the timeout value in WPT match that of Firefox in debug mode. #6719
Conversation
… that of Gecko in debug mode. One WPT test is still too slow. No reasonable timeout value made it fast enough. Therefore, I have marked the test as a timeout. Optimizing during WPT running or landing rust-lang/cargo#1826 would fix this as well, I suspect.
|
This is now once again a possibility as release builds were rolled back due to failures. Another option will be selectively generating metadata that turn off the expectations for specific tests in release only and reenabling release builds. e10s is blocked on this. |
|
|
|
Obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJul 24, 2015
One WPT test is still too slow. No reasonable timeout value made it fast
enough. Therefore, I have marked the test as a timeout. Optimizing during WPT
running or landing rust-lang/cargo#1826 would fix this as well, I suspect.
r? @jdm