Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upObey Strict-Transport-Security header #6722
Conversation
| @@ -14,7 +14,16 @@ use std::collections::HashSet; | |||
| use file_loader; | |||
| use flate2::read::{DeflateDecoder, GzDecoder}; | |||
| use hyper::client::Request; | |||
| use hyper::header::{AcceptEncoding, Accept, ContentLength, ContentType, Host, Location, qitem, Quality, QualityItem}; | |||
| use hyper::header::StrictTransportSecurity; | |||
This comment has been minimized.
This comment has been minimized.
jdm
Jul 24, 2015
Member
I'd rather use the form:
use hyper::header::{Some, Headers, Here};
use hyper::header::HeaderThatDoesNotFitOnPreviousLine;
|
I'd like to suggest that the resource task e10s lands first, as this affects messages in tasks that have pending e10s PRs. |
|
-S-awaiting-review Reviewed 3 of 3 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
|
Waiting on #6586. |
|
We're all good now! This can merge as soon as it's rebased :) |
|
@bors-servo: r+ |
|
|
Obey Strict-Transport-Security header Resolves #6703. Done: * [x] When STS headers received, add the host to the HSTS list Todo: * [ ] Persist the in-memory list so that it's reloaded on the next browser boot * [ ] Add tests to `http_loader::load` - it's pretty well completely untested right now, but it's a bit gnarly to untangle and without mocking, it's hard to deal with the dependency on making a real network request. Writing a mock request object should be doable for testing, but there's a lot going on in the function right now. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6722) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
samfoo commentedJul 24, 2015
Resolves #6703.
Done:
Todo:
http_loader::load- it's pretty well completely untested right now, but it's a bit gnarly to untangle and without mocking, it's hard to deal with the dependency on making a real network request. Writing a mock request object should be doable for testing, but there's a lot going on in the function right now.