Remove FIXME in handle_evaluate_js #6728

[sgmenda]

I removed the comments

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

[jdm]

Thanks for the patch! There are a couple changes that will be needed before we can merge this, though :)
-S-awaiting-review +S-needs-code-changes

---

Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

^{components/script/devtools.rs, line 42 [r4] (raw file):}
Please leave this FIXME; it hasn't been resolved yet. However, feel free to work on #6756 and change that!

---

^{components/script/script_task.rs, line 793 [r4] (raw file):}
nit: please revert this change.

---

^{components/script/script_task.rs, line 814 [r4] (raw file):}
nit: revert this change, please.

---

Comments from the review on Reviewable.io

[metajack]

@s142857 Are you still working on the necessary changes?

[sgmenda]

I had actually suspended working on it, I'll continue today
On 29 Jul 2015 22:26, "Jack Moffitt" notifications@github.com wrote:

@s142857 https://github.com/s142857 Are you still working on the
necessary changes?

—
Reply to this email directly or view it on GitHub
#6755 (comment).

[sgmenda]

If you want to take it up, I committed my changes so you can continue

Thanks
On 29 Jul 2015 22:28, "Sanketh Menda" mendasanketh@gmail.com wrote:

I had actually suspended working on it, I'll continue today
On 29 Jul 2015 22:26, "Jack Moffitt" notifications@github.com wrote:

@s142857 https://github.com/s142857 Are you still working on the
necessary changes?

—
Reply to this email directly or view it on GitHub
#6755 (comment).

[sgmenda]

sorry i cant finish it.

[jdm]

Ok, thanks for letting us know!