Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused allow(unrooted_must_root) attribute. #6771

Merged
merged 1 commit into from Jul 27, 2015
Merged

Remove unused allow(unrooted_must_root) attribute. #6771

merged 1 commit into from Jul 27, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 25, 2015

Review on Reviewable
@Ms2ger
Remove unused allow(unrooted_must_root) attribute.
Loading status checks…
09f0d8f
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 25, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5657

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented Jul 25, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

📌 Commit 09f0d8f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

⌛ Testing commit 09f0d8f with merge 78455ec...
bors-servo pushed a commit that referenced this pull request Jul 27, 2015
bors-servo
Auto merge of #6771 - Ms2ger:unused-attr, r=jdm
Loading status checks…
78455ec 
Remove unused allow(unrooted_must_root) attribute.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6771)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo mentioned this pull request Jul 27, 2015
Merged
@bors-servo bors-servo merged commit 09f0d8f into servo:master Jul 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:unused-attr branch Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @jdm @bors-servo @highfive
You can’t perform that action at this time.