Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MouseEvent.which to not throw #6773

Merged
merged 1 commit into from Jul 27, 2015
Merged

Fix MouseEvent.which to not throw #6773

merged 1 commit into from Jul 27, 2015

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Jul 25, 2015

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 25, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5658

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@dzbarsky
Fix MouseEvent.which to not throw
Loading status checks…
632b7f3
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 27, 2015

Sucks, but not worse than what we already had.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

📌 Commit 632b7f3 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

⌛ Testing commit 632b7f3 with merge 4e7a248...
bors-servo pushed a commit that referenced this pull request Jul 27, 2015
bors-servo
Auto merge of #6773 - dzbarsky:which, r=Ms2ger
4e7a248 
Fix MouseEvent.which to not throw



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6773)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented Jul 27, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

⌛ Testing commit 632b7f3 with merge 5b90cfd...
bors-servo pushed a commit that referenced this pull request Jul 27, 2015
bors-servo
Auto merge of #6773 - dzbarsky:which, r=Ms2ger
Loading status checks…
5b90cfd 
Fix MouseEvent.which to not throw



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6773)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo mentioned this pull request Jul 27, 2015
Merged
@bors-servo bors-servo merged commit 632b7f3 into servo:master Jul 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@dzbarsky dzbarsky deleted the dzbarsky:which branch Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@dzbarsky @hoppipolla-critic-bot @Ms2ger @bors-servo @jdm @highfive
You can’t perform that action at this time.