Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for style attributes. #678

Merged
merged 1 commit into from Aug 7, 2013

Conversation

@metajack
Copy link
Contributor

metajack commented Aug 6, 2013

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.

@metajack
Copy link
Contributor Author

metajack commented Aug 6, 2013

r? @jdm

bors-servo pushed a commit that referenced this pull request Aug 7, 2013
If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.
If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.
@jdm

This comment has been minimized.

Copy link

jdm commented on 4d71918 Aug 7, 2013

r+

This comment has been minimized.

Copy link
Owner Author

metajack replied Aug 7, 2013

@bors retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 4d71918 Aug 7, 2013

saw approval from jdm
at metajack@4d71918

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 7, 2013

merging metajack/servo/style-attributes = 4d71918 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 7, 2013

metajack/servo/style-attributes = 4d71918 merged ok, testing candidate = b017785

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 7, 2013

fast-forwarding master to auto = b017785

bors-servo pushed a commit that referenced this pull request Aug 7, 2013
If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.
@bors-servo bors-servo merged commit 4d71918 into servo:master Aug 7, 2013
1 check passed
1 check passed
default all tests passed
@metajack metajack deleted the metajack:style-attributes branch Aug 7, 2013
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.