Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement offsetParent/Top/Left/Width/Height. #6784

Merged
merged 2 commits into from Aug 4, 2015
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Fix panic when called on root node, and update test expectations.

The three tests that are marked as failures are because they use offsetWidth as a dummy to force a layout flush. Now that these exist, they expose an unrelated bug with reflow.
  • Loading branch information
gw3583 committed Aug 3, 2015
commit 39972a174e5b40966307ca32fa38325cc7fddbd0
@@ -839,8 +839,8 @@ impl<'a> WindowHelpers for &'a Window {
Some(parent_node_address) => {
let node = from_untrusted_node_address(js_runtime.rt(),
parent_node_address);
let element = ElementCast::to_ref(node.r()).unwrap();
Some(Root::from_ref(element))
let element = ElementCast::to_ref(node.r());
element.map(Root::from_ref)
}
None => {
None
@@ -0,0 +1,3 @@
[first-letter-dynamic-003a.htm]
type: reftest
expected: FAIL
@@ -0,0 +1,3 @@
[first-letter-dynamic-003b.htm]
type: reftest
expected: FAIL
@@ -0,0 +1,3 @@
[run-in-basic-017.htm]
type: reftest
expected: FAIL

This file was deleted.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.