Make Document store Ranges, and update ranges in Node subclasses

[dzbarsky]

[dzbarsky]

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/range.rs, line 861 [r1] (raw file):}
I think I had to disable these because the node algorithms like to set ranges to values that are currently invalid, but will become valid after the end of the algorithm. Thoughts on just removing these lines?

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #7265) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

r? @nox

[nox]

I'm doing this differently already, with weak references and a vector per Node. Which way should we go?

[dzbarsky]

This is what we talked about before, right? It's still not clear to me what we gain by storing ranged on a per-node basis.

For the Range updating steps in this PR, we need to be able to look up Ranges that start or end with a given node, as well as Ranges whose start or end node's descendant is a given node. This seems pretty complex to implement when Ranges are stored on various nodes. But if you have ideas for how to do this, let me know!

If we can't figure this out, we should do weak refs and vector per Document, so we can actually follow the spec and do the right thing

[nox]

@dzbarsky I introduce an unbinding context which contains the necessary information about the inclusive ancestor that was removed (its index, more or less). Still, I'm going to read through the code in this PR.

[nox]

@dzbarsky Did you have the time to look at my other branch? Which way do you think we should go?

[dzbarsky]

@nox yeah I looked briefly, let's do it your way. It ended up being nicer than I expected. Not sure if I'll have time to review it in detail in the near future though.