Implement viewport stuffs for window #1718 #6875

farodin91 · 2015-07-31T18:25:58Z


        viewport


        Merge remote-tracking branch 'upstream/master' into window


        [WIP] Implement viewport stuffs for window #1718

highfive · 2015-07-31T18:26:04Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

farodin91 · 2015-07-31T18:30:51Z

Current Problem i get

thread 'ScriptTask PipelineId(0)' has overflowed its stack
Servo exited with return value -4

if window.scroll(0,0) is excuted

jdm · 2015-07-31T18:36:30Z

It should become clear what the problem is if you run ./mach run --debugger tests/html/viewport.html and look at the backtrace when the crash occurs.

jdm · 2015-07-31T18:38:39Z

tests/html/viewport.html

+        console.log("ScrollX: "+ window.scrollX);
+      }
+      function scroll(){
+        window.scroll(0,0);


Oh, you're overwriting window.scroll with this new function :P

farodin91 · 2015-08-02T13:05:46Z

Minimal support of Scroll working.
How do I get the height/width of the entire window/document?

jdm · 2015-08-02T14:14:40Z

We can use getBoundingClientRect on the document's root element for that, as mentioned on IRC.

Also, instead of merging changes from master into your branch, could you rebase your changes instead? It makes it much easier to follow your changes when reviewing the code.

farodin91 · 2015-08-02T16:49:12Z

getBoundingClientRect doesn't work correct for me. Return (0,0)
glutin

get_position() isn't updating, is my code correct !!!
get_outer_size() isn't updating and some as get_inner_size()
resize isn't implemented
set_position should be easy to implement

farodin91 · 2015-08-02T16:50:50Z

I'm working on Linux

jdm · 2015-08-02T17:30:35Z

What if you use getBoundingClientRect on the document's body element instead?


        [WIP] Implement viewport stuffs for window #1718

farodin91 · 2015-08-02T20:21:09Z

Current status the most work. if glutin implement this stuff

jdm · 2015-08-02T20:50:15Z

Thanks for doing this! I'll give it a proper review sometime in the next couple days.

bors-servo · 2015-08-04T01:32:01Z

☔ The latest upstream changes (presumably #6784) made this pull request unmergeable. Please resolve the merge conflicts.


        Merge branch 'window' of github.com:farodin91/servo into window

Conflicts: components/compositing/compositor.rs components/msg/compositor_msg.rs components/script/dom/webidls/Window.webidl components/script/dom/window.rs components/script/script_task.rs tests/html/viewport.html


        Merging conflict


        Merging conflict 2

farodin91 · 2015-08-04T17:34:05Z

Will Squash at the end


        Merge remote-tracking branch 'upstream/master' into window

Conflicts: components/script/dom/window.rs


        Merge remote-tracking branch 'upstream/master' into window

Conflicts: components/compositing/compositor.rs components/msg/compositor_msg.rs

jdm · 2015-08-24T15:31:21Z

-S-awaiting-review +S-needs-code-changes

Reviewed 1 of 9 files at r14, 11 of 11 files at r16.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

^{components/compositing/compositor_task.rs, line 69 [r16] (raw file):}
We should send the smooth value here too.

Comments from the review on Reviewable.io

bors-servo · 2015-08-27T16:25:19Z

☔ The latest upstream changes (presumably #7401) made this pull request unmergeable. Please resolve the merge conflicts.


        Merge remote-tracking branch 'upstream/master' into window

Conflicts: components/script/dom/window.rs

dzbarsky · 2015-08-27T22:13:58Z

components/script/dom/window.rs

+
+    // https://drafts.csswg.org/cssom-view/#dom-window-devicepixelratio
+    fn DevicePixelRatio(self) -> Finite<f64> {
+        let dpr = self.window_size.get()


This will return the wrong DPR if we are running with an option specifiying DPR. (See device_pixels_per_screen_px in compositor.rs: http://mxr.mozilla.org/servo/source/components/compositing/compositor.rs#1139)
Not sure how much we care though.

This value comes from http://mxr.mozilla.org/servo/source/components/compositing/compositor.rs#779 which is derived from device_pixels_per_screen_px. Why is this wrong?

Aaah I'm having trouble reading. Ignore me and carry on.

jdm · 2015-08-27T22:40:44Z

Time to squash! Thanks!
-S-needs-rebase -S-needs-rebase +S-needs-squash

Reviewed 6 of 6 files at r17.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

bors-servo · 2015-08-28T17:55:51Z

☔ The latest upstream changes (presumably #7417) made this pull request unmergeable. Please resolve the merge conflicts.


        Merge remote-tracking branch 'upstream/master' into window

Conflicts: components/compositing/headless.rs components/script/dom/window.rs


        Auto merge of #7500 - farodin91:viewport, r=jdm

@jdm

Implement viewport functions for window #1718 @jdm r? closes #6875  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7500)


        Auto merge of #7500 - farodin91:viewport, r=jdm

@jdm

Implement viewport functions for window #1718 @jdm r? closes #6875  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7500)


        Auto merge of #7500 - farodin91:viewport, r=jdm

@jdm

Implement viewport functions for window #1718 @jdm r? closes #6875  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7500)

farodin91 added 3 commits Jul 31, 2015

viewport

40ff6cf

Merge remote-tracking branch 'upstream/master' into window

a33ad54

[WIP] Implement viewport stuffs for window #1718

Loading status checks…

a9df5f2

highfive added the S-awaiting-review label Jul 31, 2015

jdm reviewed Jul 31, 2015
View changes

farodin91 force-pushed the farodin91:window branch 2 times, most recently from f589e8c to a9df5f2 Aug 2, 2015

farodin91 force-pushed the farodin91:window branch 2 times, most recently from 11c09e6 to 160802d Aug 2, 2015

farodin91 mentioned this pull request Aug 2, 2015

update/rebase onto latest glutin servo/glutin#36

Closed

[WIP] Implement viewport stuffs for window #1718

Loading status checks…

43d6d5e

farodin91 force-pushed the farodin91:window branch from 160802d to 43d6d5e Aug 2, 2015

farodin91 changed the title ~~[WIP] Implement viewport stuffs for window #1718~~ Implement viewport stuffs for window #1718 Aug 2, 2015

jdm self-assigned this Aug 2, 2015

farodin91 added 3 commits Aug 4, 2015

Merge branch 'window' of github.com:farodin91/servo into window

cbaf83b

Conflicts: components/compositing/compositor.rs components/msg/compositor_msg.rs components/script/dom/webidls/Window.webidl components/script/dom/window.rs components/script/script_task.rs tests/html/viewport.html

Merging conflict

bb393cd

Merging conflict 2

4557a5d

Merge remote-tracking branch 'upstream/master' into window

Loading status checks…

d289878

Conflicts: components/script/dom/window.rs

highfive added S-needs-rebase and removed S-awaiting-merge labels Aug 20, 2015

Merge remote-tracking branch 'upstream/master' into window

Loading status checks…

3f3b176

Conflicts: components/compositing/compositor.rs components/msg/compositor_msg.rs

jdm removed the S-needs-rebase label Aug 24, 2015

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 24, 2015

highfive added S-needs-rebase and removed S-awaiting-merge labels Aug 27, 2015

Merge remote-tracking branch 'upstream/master' into window

Loading status checks…

5274eab

Conflicts: components/script/dom/window.rs

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 27, 2015

dzbarsky reviewed Aug 27, 2015
View changes

jdm added S-needs-squash and removed S-needs-rebase labels Aug 27, 2015

highfive added S-needs-rebase and removed S-awaiting-merge labels Aug 28, 2015

jdm removed the S-awaiting-review label Aug 28, 2015

Merge remote-tracking branch 'upstream/master' into window

Loading status checks…

f655800

Conflicts: components/compositing/headless.rs components/script/dom/window.rs

highfive added the S-awaiting-review label Sep 1, 2015

farodin91 mentioned this pull request Sep 1, 2015

Implement viewport functions for window #1718 #7500

Merged

farodin91 closed this Sep 1, 2015

farodin91 deleted the farodin91:window branch Sep 1, 2015

paulrouget added the A-browserhtml/P3 label Jan 26, 2016

servo / servo

Implement viewport stuffs for window #1718 #6875

Implement viewport stuffs for window #1718 #6875

farodin91 commented Jul 31, 2015

highfive commented Jul 31, 2015

farodin91 commented Jul 31, 2015

jdm commented Jul 31, 2015

This comment has been minimized.

This comment has been minimized.

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

farodin91 commented Aug 2, 2015

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

bors-servo commented Aug 4, 2015

farodin91 commented Aug 4, 2015

jdm commented Aug 24, 2015

bors-servo commented Aug 27, 2015

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdm commented Aug 27, 2015

bors-servo commented Aug 28, 2015

servo / servo

Join GitHub today

Implement viewport stuffs for window #1718 #6875

Implement viewport stuffs for window #1718 #6875

Conversation

farodin91 commented Jul 31, 2015

highfive commented Jul 31, 2015

farodin91 commented Jul 31, 2015

jdm commented Jul 31, 2015

This comment has been minimized.

jdm Jul 31, 2015

This comment has been minimized.

farodin91 Aug 2, 2015

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

farodin91 commented Aug 2, 2015

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

farodin91 commented Aug 2, 2015

jdm commented Aug 2, 2015

bors-servo commented Aug 4, 2015

farodin91 commented Aug 4, 2015

jdm commented Aug 24, 2015

bors-servo commented Aug 27, 2015

This comment has been minimized.

dzbarsky Aug 27, 2015

This comment has been minimized.

jdm Aug 27, 2015

This comment has been minimized.

dzbarsky Aug 27, 2015

jdm commented Aug 27, 2015

bors-servo commented Aug 28, 2015