Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run our reftests with wptrunner #6899

Closed
wants to merge 5 commits into from
Closed

Run our reftests with wptrunner #6899

wants to merge 5 commits into from

Conversation

@sgmenda
Copy link
Contributor

sgmenda commented Aug 2, 2015

#5618, It allows us to run reftests using wptrunner.

I've done the needed changes, as proposed by @jdm .

Hopefully this is it.

Thanks @jdm @SimonSapin @wafflespeanut

Review on Reviewable

boghison and others added 5 commits Jul 23, 2015
32-bit floats are not enough to hold timestamps since the epoch and
result in jank.
s142857
Ability to run reftests using wptrunner
s142857
@highfive
Copy link

highfive commented Aug 2, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

@jdm
Copy link
Member

jdm commented Aug 2, 2015

@s142857 There's an issue that's making it difficult to evaluate these changes: this git branch seems to include several commits that are different than servo/master in some way. I recommend resetting the branch to a revision of the official master, then cherry-picking your two commits (git cherry-pick 5fb40ad; git cherry-pick 3a922af) on top of it.

Additionally, it will be much easier to read if the two commits are squashed together in one.

@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2015

The latest upstream changes (presumably #6895) made this pull request unmergeable. Please resolve the merge conflicts.

@sgmenda
Copy link
Contributor Author

sgmenda commented Aug 3, 2015

ill do it

@sgmenda sgmenda closed this Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.