Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low hanging Dromaeo fruit #6900

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

script: Mark some DOM methods used in Dromaeo as pure.

We can't LICM them until we are codegen-ing `JSTypedMethodJitInfo` (see
  • Loading branch information
pcwalton committed Sep 17, 2015
commit f6bc285fdfcfe7c1eaeacd99808a2175c7807af6
@@ -33,15 +33,19 @@ interface Element : Node {

[Constant]
readonly attribute NamedNodeMap attributes;
[Pure]
DOMString? getAttribute(DOMString name);
[Pure]
DOMString? getAttributeNS(DOMString? namespace, DOMString localName);
[Throws]
void setAttribute(DOMString name, DOMString value);
[Throws]
void setAttributeNS(DOMString? namespace, DOMString name, DOMString value);
void removeAttribute(DOMString name);
void removeAttributeNS(DOMString? namespace, DOMString localName);
[Pure]
boolean hasAttribute(DOMString name);
[Pure]
boolean hasAttributeNS(DOMString? namespace, DOMString localName);

[Throws]
@@ -50,8 +54,11 @@ interface Element : Node {
[Throws]
boolean matches(DOMString selectors);

[Pure]
HTMLCollection getElementsByTagName(DOMString localName);
[Pure]
HTMLCollection getElementsByTagNameNS(DOMString? namespace, DOMString localName);
[Pure]
HTMLCollection getElementsByClassName(DOMString classNames);
};

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.