Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLock and flush stdout in Window#alert. #6917
Merged
+5
−1
Conversation
We use alert() to communicate test results to wptrunner. Unfortunately, sometimes the alert output is interleaved with other output on stdout, causing wptrunner to classify the test result as a timeout. I hope this will avoid that scenario.
|
@bors-servo r+ -S-awaiting-review +S-awaiting-merge Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2015
Lock and flush stdout in Window#alert. We use alert() to communicate test results to wptrunner. Unfortunately, sometimes the alert output is interleaved with other output on stdout, causing wptrunner to classify the test result as a timeout. I hope this will avoid that scenario. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6917) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2015
Lock and flush stdout in Window#alert. We use alert() to communicate test results to wptrunner. Unfortunately, sometimes the alert output is interleaved with other output on stdout, causing wptrunner to classify the test result as a timeout. I hope this will avoid that scenario. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6917) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedAug 3, 2015
We use alert() to communicate test results to wptrunner. Unfortunately,
sometimes the alert output is interleaved with other output on stdout,
causing wptrunner to classify the test result as a timeout. I hope this will
avoid that scenario.