Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Harfbuzz callback functions in a static var #6937

Merged
merged 2 commits into from Aug 4, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 3, 2015

r? gw

Review on Reviewable

@highfive
Copy link

highfive commented Aug 3, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@pcwalton
Copy link
Contributor

pcwalton commented Aug 3, 2015

that is r? @glennw

@glennw
Copy link
Member

glennw commented Aug 3, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2015

📌 Commit 47a0d49 has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

Testing commit 47a0d49 with merge 3a183b0...

bors-servo pushed a commit that referenced this pull request Aug 4, 2015
Store Harfbuzz callback functions in a static var

r? gw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6937)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

💔 Test failed - linux3

@jdm
Copy link
Member

jdm commented Aug 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

Testing commit 47a0d49 with merge d77f941...

bors-servo pushed a commit that referenced this pull request Aug 4, 2015
Store Harfbuzz callback functions in a static var

r? gw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6937)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 47a0d49 into servo:master Aug 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:hb_funcs branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.