Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for issue #6768. Refactor ReadData and BlobBody #6944
Conversation
|
Thanks for doing this work @r0e! However, there are a number of indentation changes that are either incorrect (r0e@00c7a05#diff-86a64de2e20a4f0e05816b3c9256087eR92, r0e@00c7a05#diff-86a64de2e20a4f0e05816b3c9256087eR108, etc.) or at least quite distracting from the important changes here. Would you be able to undo those changes, or at least split them into a separate commit for easier review? |
|
Whoops, I thought Vim's "=G" command would take care of all my indentation errors. Guess it created more problems than it solved... I'll get on it. |
Merged common fields of BlobBody and ReadData into a new struct to avoid passing redundant information
|
@bors-servo: r+ Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
|
|
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry I swear we're actually fixing #6818 simultaneously. Until this we're just getting super unlucky in this PR. |
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Fix for issue #6768. Refactor ReadData and BlobBody Fix for issue #6768. Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944) <!-- Reviewable:end -->
r0e commentedAug 4, 2015
Fix for issue #6768.
Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions.