Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning police. #6949

Closed
wants to merge 1 commit into from
Closed

Warning police. #6949

wants to merge 1 commit into from
+1 −2

Conversation

@jdm
Copy link
Member

jdm commented Aug 4, 2015

Review on Reviewable
@jdm
Warning police.
Loading status checks…
8bb6f91
@metajack
Copy link
Contributor

metajack commented Aug 4, 2015

@bors-servo r+

-S-awaiting-review +S-awaiting-merge

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

📌 Commit 8bb6f91 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

⌛ Testing commit 8bb6f91 with merge 2789309...
bors-servo pushed a commit that referenced this pull request Aug 4, 2015
bors-servo
Auto merge of #6949 - jdm:warnings, r=metajack
2789309 
Warning police.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

💔 Test failed - linux3
@SimonSapin SimonSapin mentioned this pull request Aug 4, 2015
Closed
@SimonSapin
Copy link
Member

SimonSapin commented Aug 4, 2015

#6958

/css21_dev/html4/counter-reset-increment-002.htm
------------------------------------------------
CRASH expected TIMEOUT [Parent]

There’s also a remaining warning:

/home/servo/buildbot/slave/linux3/build/components/gfx/text/shaping/harfbuzz.rs:30:16: 30:42 warning: unused import, #[warn(unused_imports)] on by default
/home/servo/buildbot/slave/linux3/build/components/gfx/text/shaping/harfbuzz.rs:30 use harfbuzz::{RUST_hb_font_funcs_destroy};
                                                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
@SimonSapin SimonSapin mentioned this pull request Aug 4, 2015
Merged
jdm added a commit that referenced this pull request Aug 4, 2015
@jdm @SimonSapin
Warning police.
Loading status checks…
039929d 
Closes #6949.
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 4, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

⌛ Testing commit 8bb6f91 with merge 93dbc01...
bors-servo pushed a commit that referenced this pull request Aug 4, 2015
bors-servo
Auto merge of #6949 - jdm:warnings, r=metajack
93dbc01 
Warning police.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

💔 Test failed - linux3
@jdm
Copy link
Member Author

jdm commented Aug 4, 2015

@bors-servo: retry
@jdm jdm closed this Aug 4, 2015
bors-servo pushed a commit that referenced this pull request Aug 5, 2015
bors-servo
Auto merge of #6959 - servo:warnings_, r=jdm
bc3581e 
Fix warnings

Adds on top of #6949.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6959)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Aug 5, 2015
bors-servo
Auto merge of #6959 - servo:warnings_, r=jdm
Loading status checks…
0d8825c 
Fix warnings

Adds on top of #6949.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6959)
<!-- Reviewable:end -->
josiahdaniels added a commit to josiahdaniels/servo that referenced this pull request Sep 28, 2015
@jdm @josiahdaniels
Warning police.
a6e7bb2 
Closes servo#6949.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @metajack @bors-servo @SimonSapin @Ms2ger @highfive
You can’t perform that action at this time.