Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade cssparser #6957
Upgrade cssparser #6957
Conversation
|
@bors-servo r+ |
|
|
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
|
|
@bors-servo r=larsbergstrom |
|
|
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
|
|
|
I don’t know what’s going on, I can’t reproduce this locally. In fact, when running
|
|
Rerun this. It might have been due to me mucking with buildbot. |
|
@bors-servo retry |
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
|
|
Mystery solved: the difference between my system and the builders is that I have the Ahem font installed: #6195. Working on a fix. |
|
This should be rebased on top of #7013 once that lands. |
|
@bors-servo r=larsbergstrom Carrying previous r+ with test expectations updated based on running |
|
|
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
|
|
I don’t know if this is intermittent, but I’m pretty sure it’s not cause by this PR:
|
|
Might be due to infra issues that Lars was fixing? That definitely looks like a weird outside-of-CI error. |
|
@bors-servo retry
|
|
It's possible that I was being too rude with my zombie-process-killing. Sorry! |
Pick up the fix for servo/rust-cssparser#76
|
If this bounces again you should also delete tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-{3,4,5}.html.ini because those are currently disabled but will now pass. |
|
@bors-servo r=larsbergstrom+dzbarsky |
|
|
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
SimonSapin commentedAug 4, 2015
Pick up the fix for servo/rust-cssparser#76
*.inifiles removal based on running./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*, I didn’t run the whole test suite.r? @larsbergstrom