Upgrade cssparser #6957
Merged
Upgrade cssparser #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit a18b1ba has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 4, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
💔 Test failed - mac1 |
|
@bors-servo r=larsbergstrom |
|
📌 Commit 4b0d25b has been approved by |
jdm
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
💔 Test failed - linux3 |
|
jdm
added
S-tests-failed
|
I don’t know what’s going on, I can’t reproduce this locally. In fact, when running |
|
Rerun this. It might have been due to me mucking with buildbot. |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
💔 Test failed - mac2 |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
💔 Test failed - mac3 |
|
Mystery solved: the difference between my system and the builders is that I have the Ahem font installed: #6195. Working on a fix. |
|
This should be rebased on top of #7013 once that lands. |
highfive
added
S-awaiting-review
|
@bors-servo r=larsbergstrom Carrying previous r+ with test expectations updated based on running |
|
📌 Commit 2f47830 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 7, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
|
💔 Test failed - mac3 |
|
I don’t know if this is intermittent, but I’m pretty sure it’s not cause by this PR: |
|
Might be due to infra issues that Lars was fixing? That definitely looks like a weird outside-of-CI error. |
|
@bors-servo retry
|
|
It's possible that I was being too rude with my zombie-process-killing. Sorry! |
Pick up the fix for servo/rust-cssparser#76
|
If this bounces again you should also delete tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-{3,4,5}.html.ini because those are currently disabled but will now pass. |
|
@bors-servo r=larsbergstrom+dzbarsky |
|
📌 Commit 90d7d11 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 7, 2015
Upgrade cssparser Pick up the fix for servo/rust-cssparser#76 `*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up the fix for servo/rust-cssparser#76
*.inifiles removal based on running./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*, I didn’t run the whole test suite.r? @larsbergstrom