Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cssparser #6957

Merged
merged 1 commit into from Aug 7, 2015
Merged

Upgrade cssparser #6957

merged 1 commit into from Aug 7, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 4, 2015

Pick up the fix for servo/rust-cssparser#76

*.ini files removal based on running ./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*, I didn’t run the whole test suite.

r? @larsbergstrom

Review on Reviewable

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

📌 Commit a18b1ba has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

Testing commit a18b1ba with merge d53e871...

bors-servo pushed a commit that referenced this pull request Aug 4, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

💔 Test failed - mac1

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 4, 2015

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

📌 Commit 4b0d25b has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

Testing commit 4b0d25b with merge a909f72...

bors-servo pushed a commit that referenced this pull request Aug 5, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

💔 Test failed - linux3

@jdm
Copy link
Member

jdm commented Aug 5, 2015


/css21_dev/html4/background-color-052.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-053.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-049.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-054.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-073.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-074.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-070.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-075.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-093.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-094.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-090.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-095.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-113.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-114.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-110.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/background-color-115.htm
-----------------------------------------
FAIL [Parent]
/css21_dev/html4/c63-color-000.htm
----------------------------------
FAIL [Parent]
/css21_dev/html4/color-001.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-002.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-003.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-004.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-005.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-006.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-007.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-008.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-009.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-011.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-010.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-012.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-013.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-015.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-014.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-016.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-017.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-018.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-019.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-020.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-021.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-022.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-023.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-024.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-025.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-026.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-027.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-028.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-029.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-031.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-032.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-033.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-034.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-035.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-036.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-037.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-038.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-039.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-040.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-041.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-042.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-043.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-044.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-045.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-046.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-047.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-048.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-050.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-051.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-049.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-052.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-055.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-053.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-054.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-056.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-058.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-057.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-059.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-061.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-062.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-060.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-063.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-064.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-066.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-065.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-067.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-069.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-068.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-071.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-072.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-070.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-073.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-076.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-074.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-075.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-077.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-078.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-079.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-081.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-082.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-080.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-086.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-085.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-087.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-088.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-089.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-091.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-092.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-090.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-093.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-094.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-096.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-095.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-097.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-098.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-099.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-101.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-102.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-100.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-103.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-106.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-104.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-105.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-107.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-108.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-109.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-111.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-112.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-110.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-113.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-116.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-114.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-115.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-117.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-118.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-119.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-121.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-122.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-120.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-123.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-126.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-124.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-127.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-125.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-128.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-129.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-131.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-130.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-132.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-133.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-134.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-135.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-136.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-137.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-139.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-138.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-140.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-141.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-142.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-143.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-144.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-174.htm
------------------------------
FAIL [Parent]
/css21_dev/html4/color-145.htm
------------------------------
FAIL [Parent]
@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Aug 5, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 5, 2015

I don’t know what’s going on, I can’t reproduce this locally. In fact, when running mach build -r && mach test-css --release on a merge of this branch with master I get even more PASS expected FAIL results that seem unrelated to colors:

Unexpected results: 285 (FAIL: 6, PASS: 279)

[…]

/css21_dev/html4/abs-pos-non-replaced-vlr-121.htm
-------------------------------------------------
PASS expected FAIL [Parent]
@metajack
Copy link
Contributor

metajack commented Aug 5, 2015

Rerun this. It might have been due to me mucking with buildbot.

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 5, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

Testing commit 4b0d25b with merge 1d180d1...

bors-servo pushed a commit that referenced this pull request Aug 5, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

💔 Test failed - mac2

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 5, 2015

@bors-servo retry

command timed out: 1200 seconds without output running ['./mach', 'test-ref', '--kind', 'cpu'], attempting to kill
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

Testing commit 4b0d25b with merge 31137cb...

bors-servo pushed a commit that referenced this pull request Aug 5, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

💔 Test failed - mac3

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 5, 2015

Mystery solved: the difference between my system and the builders is that I have the Ahem font installed: #6195. Working on a fix.

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 5, 2015

This should be rebased on top of #7013 once that lands.

@SimonSapin SimonSapin force-pushed the cssparserup branch from 4b0d25b to 8c5fee1 Aug 7, 2015
@SimonSapin SimonSapin force-pushed the cssparserup branch from 8c5fee1 to 2f47830 Aug 7, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 7, 2015

@bors-servo r=larsbergstrom

Carrying previous r+ with test expectations updated based on running ./mach test-css --release locally with Ahem uninstalled.

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

📌 Commit 2f47830 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

Testing commit 2f47830 with merge eedd3a1...

bors-servo pushed a commit that referenced this pull request Aug 7, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

💔 Test failed - mac3

@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 7, 2015

I don’t know if this is intermittent, but I’m pretty sure it’s not cause by this PR:

failed to run custom build command for `mozjs_sys v0.0.0 (https://github.com/servo/mozjs#5da854e6)`
Process didn't exit successfully: `/Users/servo/buildbot/slave/mac3/build/target/release/build/mozjs_sys-e411d274df144795/build-script-build` (exit code: 101)
--- stdout
cd /Users/servo/buildbot/slave/mac3/build/target/release/build/mozjs_sys-e411d274df144795/out && \
    MOZ_TOOLS="" CC="gcc" CPP="gcc -E" CXX="g++" AR="ar" \
    /Users/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/configure --enable-gczeal --disable-jemalloc
creating cache ./config.cache
checking host system type... x86_64-apple-darwin14.4.0

[lots more output]

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../lib/libicui18n.a(uspoof_wsconf.o) has no symbols
make[4]: *** [buildicu] Killed: 9
make[3]: *** [config/external/icu/target] Error 2
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [all] Error 2
thread '<main>' panicked at 'assertion failed: result.success()', /Users/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/build.rs:16

[lots more output]
@metajack
Copy link
Contributor

metajack commented Aug 7, 2015

Might be due to infra issues that Lars was fixing? That definitely looks like a weird outside-of-CI error.

@metajack
Copy link
Contributor

metajack commented Aug 7, 2015

@bors-servo retry

  • infra issues
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 7, 2015

It's possible that I was being too rude with my zombie-process-killing. Sorry!

Pick up the fix for servo/rust-cssparser#76
@dzbarsky
Copy link
Member

dzbarsky commented Aug 7, 2015

If this bounces again you should also delete tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-{3,4,5}.html.ini because those are currently disabled but will now pass.

@SimonSapin SimonSapin force-pushed the cssparserup branch from 2f47830 to 90d7d11 Aug 7, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 7, 2015

@bors-servo r=larsbergstrom+dzbarsky

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

📌 Commit 90d7d11 has been approved by larsbergstrom+dzbarsky

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

Testing commit 90d7d11 with merge 9bd5291...

bors-servo pushed a commit that referenced this pull request Aug 7, 2015
Upgrade cssparser

Pick up the fix for servo/rust-cssparser#76

`*.ini` files removal based on running `./mach test-css tests/wpt/css-tests/css21_dev/html4/*color*`, I didn’t run the whole test suite.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 90d7d11 into master Aug 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the cssparserup branch Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.