Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun our reftests with wptrunner rev5 #6961
Closed
Conversation
highfive
commented
Aug 4, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
to make this small
|
@s142857 There are duplicate copies of tests in both tests/wpt/mozilla/css an tests/wpt/mozilla/tests/css, and that we still don't have MANIFEST.json changes for the vast majority of the tests. Please open a new PR using a new branch (based off of servo/master) that only converts one test as previously asked. There are too many things going wrong and it's impossible to review this PR right now to figure out why they're happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sgmenda commentedAug 4, 2015
moved tests from ref to wpt, to enable use of wptrunner.
#5618
Thanks,