Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by negative numbers in list counters. #6979

Merged
merged 1 commit into from Aug 5, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 4, 2015

Fixes #6818. The test still fails because of #6978.

r? @pcwalton

Review on Reviewable

@pcwalton
Copy link
Contributor

pcwalton commented Aug 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

📌 Commit 6650d03 has been approved by pcwalton

@mbrubeck mbrubeck force-pushed the mbrubeck:counter branch from 6650d03 to 35ba731 Aug 4, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Aug 4, 2015

@bors-servo r=pcwalton

(oops, forgot to commit the metadata change)

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2015

📌 Commit 35ba731 has been approved by pcwalton

@jdm
Copy link
Member

jdm commented Aug 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

Testing commit 35ba731 with merge b9f0019...

bors-servo pushed a commit that referenced this pull request Aug 5, 2015
Fix crash caused by negative numbers in list counters.

Fixes #6818.  The test still fails because of #6978.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6979)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 35ba731 into servo:master Aug 5, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:counter branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.