Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Code in FileReader #6753 #7001

Merged
merged 1 commit into from Aug 6, 2015
Merged

Remove Unnecessary Code in FileReader #6753 #7001

merged 1 commit into from Aug 6, 2015

Conversation

@farodin91
Copy link
Contributor

farodin91 commented Aug 5, 2015

@jdm r?

Review on Reviewable
@farodin91
Remove Unnecessary Code in FileReader #6753
Loading status checks…
4162042
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 5, 2015

@bors-servo r+

Thank you for the PR.
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 6, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2015

📌 Commit 4162042 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2015

⌛ Testing commit 4162042 with merge ddd2840...
bors-servo pushed a commit that referenced this pull request Aug 6, 2015
bors-servo
Auto merge of #7001 - farodin91:filereader, r=Ms2ger
Loading status checks…
ddd2840 
Remove Unnecessary Code in FileReader #6753

@jdm r?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7001)
<!-- Reviewable:end -->
@farodin91
Copy link
Contributor Author

farodin91 commented Aug 6, 2015

Why Travis CI doesn't test this?
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 6, 2015

Travis can't handle building Servo. However, our own infrastructure is busy building this PR, and should be done in 20 minutes or so.
@jdm jdm added the S-awaiting-merge label Aug 6, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3
@bors-servo bors-servo merged commit 4162042 into servo:master Aug 6, 2015
1 check passed
1 check passed
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 6, 2015
Merged
@farodin91
Copy link
Contributor Author

farodin91 commented Aug 6, 2015

@Ms2ger travis run normally the tidy test. Why not here?
@farodin91 farodin91 deleted the farodin91:filereader branch Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@farodin91 @Ms2ger @bors-servo @jdm
You can’t perform that action at this time.