Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLock stderr while printing the alert() message. #7027
Merged
Conversation
|
@bors-servo: r+ |
|
|
|
@bors-servo p=1 Bumping priority up since this will stabilize intermittents. |
bors-servo
pushed a commit
that referenced
this pull request
Aug 6, 2015
Lock stderr while printing the alert() message. 2a7f262 was unsufficient for the case where the interleaved output was actually on stderr rather than stdout, such as output from the error macro. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7027) <!-- Reviewable:end -->
|
|
|
|
@bors-servo r=jdm |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 6, 2015
Lock stderr while printing the alert() message. 2a7f262 was unsufficient for the case where the interleaved output was actually on stderr rather than stdout, such as output from the error macro. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7027) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedAug 6, 2015
2a7f262 was unsufficient for the case where
the interleaved output was actually on stderr rather than stdout, such as
output from the error macro.