Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLTableElement#createTBody #7089

Merged
merged 1 commit into from Aug 9, 2015
Merged

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Aug 8, 2015

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 8, 2015

Thank you for your PR.

-S-awaiting-review +S-needs-code-changes


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.


components/script/dom/htmltableelement.rs, line 92 [r1] (raw file):
Feel free to make this return HTMLTableSectionElement, even though that's not what the spec says.


components/script/dom/htmltableelement.rs, line 101 [r1] (raw file):
Indentation is weird; maybe brace the closure.


components/script/dom/htmltableelement.rs, line 103 [r1] (raw file):
Maybe use and_then.


components/script/dom/htmltableelement.rs, line 106 [r1] (raw file):
Just r() (on RootedReference).


Comments from the review on Reviewable.io

@dzbarsky dzbarsky force-pushed the dzbarsky:createtbody branch from a82f875 to 992a1e1 Aug 8, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Aug 8, 2015

Review status: 2 of 4 files reviewed at latest revision, 4 unresolved discussions, some commit checks pending.


components/script/dom/htmltableelement.rs, line 106 [r1] (raw file):
Oh I thought that was gone after smup. Looks like it's back or something.


Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 9, 2015

-S-awaiting-review +S-awaiting-merge

@bors-servo r+


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

📌 Commit 992a1e1 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

Testing commit 992a1e1 with merge 454b2a7...

bors-servo pushed a commit that referenced this pull request Aug 9, 2015
Implement HTMLTableElement#createTBody



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7089)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

💔 Test failed - linux2

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 9, 2015

/html/dom/interfaces.html
-------------------------
PASS expected FAIL HTMLTableElement interface: operation createTBody()
PASS expected FAIL HTMLTableElement interface: document.createElement("table") must inherit property "createTBody" with the proper type (10)
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

The latest upstream changes (presumably #7063) made this pull request unmergeable. Please resolve the merge conflicts.

@dzbarsky dzbarsky force-pushed the dzbarsky:createtbody branch from 992a1e1 to 54adae2 Aug 9, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 9, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

📌 Commit 54adae2 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

Testing commit 54adae2 with merge 44d93bc...

bors-servo pushed a commit that referenced this pull request Aug 9, 2015
Implement HTMLTableElement#createTBody



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7089)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 54adae2 into servo:master Aug 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.