Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some imports are used in linux only. Fixes #7088. #7105

Merged
merged 1 commit into from Aug 9, 2015

Conversation

@connorimes
Copy link
Contributor

connorimes commented Aug 9, 2015

Imports are used in Linux.

Review on Reviewable

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 9, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

📌 Commit 926cb90 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

Testing commit 926cb90 with merge 6169b51...

bors-servo pushed a commit that referenced this pull request Aug 9, 2015
Some imports are used in linux only. Fixes #7088.

Imports are used in Linux.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7105)
<!-- Reviewable:end -->
@connorimes
Copy link
Contributor Author

connorimes commented Aug 9, 2015

I also mentioned on the original report - I can't test this on a mac where the warnings appear. Do the integration tests do all platforms?

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

💔 Test failed - linux2

@jdm
Copy link
Member

jdm commented Aug 9, 2015

@bors-servo: retry

  • now-reverted commit that broke running tests
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

Testing commit 926cb90 with merge abf7399...

bors-servo pushed a commit that referenced this pull request Aug 9, 2015
Some imports are used in linux only. Fixes #7088.

Imports are used in Linux.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7105)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 926cb90 into servo:master Aug 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.