Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Servo tests to be built/run with --release mode #7124

Merged
merged 1 commit into from Aug 10, 2015
Merged

Allow Servo tests to be built/run with --release mode #7124

merged 1 commit into from Aug 10, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Aug 10, 2015

Fixes #5075

Review on Reviewable
@frewsxcv
Allow Servo tests to be built/run with --release mode
Loading status checks…
f873db5 
Fixes #5075
@metajack
Copy link
Contributor

metajack commented Aug 10, 2015

@bors-servo r+

Note that this is going to greatly regress CI times until --release is added in the right places. Without that running test-ref will cause a full rebuild of Servo.

Also, please file a bug for making --release and --dev handling uniform across commands. build-cef is another where --release is an option and dev is default, but other commands require one or the other.

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

📌 Commit f873db5 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

⌛ Testing commit f873db5 with merge 8b13a79...
bors-servo pushed a commit that referenced this pull request Aug 10, 2015
bors-servo
Auto merge of #7124 - frewsxcv:test-ref-release, r=metajack
Loading status checks…
8b13a79 
Allow Servo tests to be built/run with --release mode

Fixes #5075

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7124)
<!-- Reviewable:end -->
@frewsxcv frewsxcv mentioned this pull request Aug 10, 2015
Open
@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 10, 2015

Also, please file a bug for making --release and --dev handling uniform across commands

#7127
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

💔 Test failed - mac2
@metajack
Copy link
Contributor

metajack commented Aug 10, 2015

@bors-servo retry

  • infra issues
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

⚡ Previous build results for android, gonk, linux1, linux2, mac1, mac3 are reusable. Rebuilding only mac2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3
@bors-servo bors-servo merged commit f873db5 into servo:master Aug 10, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:test-ref-release branch Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@frewsxcv @metajack @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.