Make BrowsingContext JS-managed.

[Ms2ger]

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[Ms2ger]

r? @jdm

Please review carefully; I mostly copy/pasted this together.

[bors-servo]

☔ The latest upstream changes (presumably #7191) made this pull request unmergeable. Please resolve the merge conflicts.

[jdm]

-S-needs-rebase -S-awaiting-review +S-needs-code-changes

---

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

^{components/script/dom/browsercontext.rs, line 32 [r1] (raw file):}
Don't need this any more.

---

^{components/script/dom/browsercontext.rs, line 64 [r1] (raw file):}
We'll need a more informative comment here. I also haven't been able to determine how the JSClass value in ProxyOptions gets used yet.

---

^{components/script/dom/browsercontext.rs, line 70 [r1] (raw file):}
I don't think this is necessary, given the operations being performed here.

---

^{components/script/dom/browsercontext.rs, line 71 [r1] (raw file):}
I think we can get away with just passing Box::into_raw inline here.

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #7244) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

^{components/script/dom/browsercontext.rs, line 64 [r1] (raw file):}
I was going to use it for the inner/outer hooks, but those are being removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1125423.

---

^{components/script/dom/browsercontext.rs, line 71 [r1] (raw file):}
raw is used below.

---

Comments from the review on Reviewable.io

[jdm]

@bors-servo: r+

---

Reviewed 6 of 6 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit f86502f has been approved by jdm

[bors-servo]

⌛ Testing commit f86502f with merge 88fe14e...

[bors-servo]

💔 Test failed - linux-rel

[eefriedman]

@bors-servo retry #8311

[bors-servo]

⌛ Testing commit f86502f with merge b4d2341...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt