Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Make absolutely-positioned elements with `z-index: auto` not stacking contexts. #7137

Merged
merged 2 commits into from Aug 11, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Aug 10, 2015

Improves many sites.

Closes #7069.

r? @glennw

Review on Reviewable

@pcwalton pcwalton force-pushed the pcwalton:absolute-stacking-contexts branch from a71f5d8 to 1610e9a Aug 10, 2015
@pcwalton pcwalton changed the title layout: Make absolutely-positioned elements with `z-index: auto` not containing blocks. layout: Make absolutely-positioned elements with `z-index: auto` not stacking contexts. Aug 10, 2015
@glennw
Copy link
Member

glennw commented Aug 10, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

📌 Commit 1610e9a has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

Testing commit 1610e9a with merge 2050f61...

bors-servo pushed a commit that referenced this pull request Aug 10, 2015
layout: Make absolutely-positioned elements with `z-index: auto` not stacking contexts.

Improves many sites.

Closes #7069.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7137)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2015

💔 Test failed - linux2

@jdm
Copy link
Member

jdm commented Aug 10, 2015

/css21_dev/html4/content-177.htm
--------------------------------
PASS expected FAIL [Parent]
/css21_dev/html4/insert-inline-in-blocks-n-inlines-begin-003.htm
----------------------------------------------------------------
FAIL [Parent]
/css21_dev/html4/insert-inline-in-blocks-n-inlines-middle-003.htm
-----------------------------------------------------------------
FAIL [Parent]
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2015

The latest upstream changes (presumably #7090) made this pull request unmergeable. Please resolve the merge conflicts.

@pcwalton pcwalton force-pushed the pcwalton:absolute-stacking-contexts branch from 1610e9a to 67d86ac Aug 11, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 11, 2015

@bors-servo: r=glennw

@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2015

📌 Commit 67d86ac has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2015

Testing commit 67d86ac with merge 7ce4726...

bors-servo pushed a commit that referenced this pull request Aug 11, 2015
layout: Make absolutely-positioned elements with `z-index: auto` not stacking contexts.

Improves many sites.

Closes #7069.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7137)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 67d86ac into servo:master Aug 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.