remove ScriptListener

[vectorijk]

Fix issue #7175 and for code review

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

[Ms2ger]

-S-awaiting-review +S-awaiting-answer

Thank you for your PR. I have one question below.

---

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/script_task.rs, line 1289 [r1] (raw file):}
I don't understand why we need these RefMut::map calls.

---

Comments from the review on Reviewable.io

[vectorijk]

^{components/script/script_task.rs, line 1289 [r1] (raw file):}
cause self.compositor return type is DOMRefCell<IpcSender<ScriptToCompositorMsg>> and self.compositor.borrow_mut() return type isRefMut<'_, IpcSender<ScriptToCompositorMsg>>. So I use RefMut::map to get IpcSender<T>. Do you have better way to get it?

---

Comments from the review on Reviewable.io

[jdm]

We can just dereference RefMut<T> via * to get &mut T.

[vectorijk]

@jdm Okay, Got it~ I might try dereference RefMut<T> via * before. But I gave up this method cause I didn't use correct parentheses. And I will revise this for code review later.

[vectorijk]

^{components/script/script_task.rs, line 1289 [r1] (raw file):}
Okay, I changed that.

---

Comments from the review on Reviewable.io

[Ms2ger]

-S-awaiting-review +S-needs-code-changes

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/script_task.rs, line 1289 [r1] (raw file):}
Thanks. Could you try without the explicit dereferencing too (i.e., self.compositor.borrow_mut().send(ScriptToCompositorMsg::Exit).unwrap();

---

Comments from the review on Reviewable.io

[vectorijk]

^{components/script/script_task.rs, line 1289 [r1] (raw file):}
@Ms2ger Sure.

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #7006) made this pull request unmergeable. Please resolve the merge conflicts.

[vectorijk]

@Ms2ger @jdm rebased it.

[Ms2ger]

Thank you!

@bors-servo r+

[bors-servo]

📌 Commit 270df6b has been approved by Ms2ger

[bors-servo]

⌛ Testing commit 270df6b with merge 5ab9aa5...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3