Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement WebSocket#binaryType #7214
Conversation
highfive
commented
Aug 14, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
highfive
commented
Aug 14, 2015
|
Thank you for your PR! -S-awaiting-review +S-needs-code-changes +S-needs-squash Reviewed 1 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r4. components/script/dom/websocket.rs, line 52 [r4] (raw file): components/script/dom/websocket.rs, line 441 [r4] (raw file): Comments from the review on Reviewable.io |
aea3492
to
1f1dbfa
|
@Ms2ger addressed your comments and squashed |
|
Thank you! @bors-servo r+ |
|
|
Implement WebSocket#binaryType Closes #7098 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214) <!-- Reviewable:end -->
|
|
|
Looks like you missed one more:
|
1f1dbfa
to
e92f462
|
Whoops. Re-pushed. |
|
@bors-servo: r=Ms2ger |
|
|
Implement WebSocket#binaryType Closes #7098 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214) <!-- Reviewable:end -->
tomjakubowski commentedAug 14, 2015
Closes #7098