Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebSocket#binaryType #7214

Merged
merged 1 commit into from Aug 16, 2015

Conversation

@tomjakubowski
Copy link
Contributor

tomjakubowski commented Aug 14, 2015

Closes #7098

Review on Reviewable

@highfive
Copy link

highfive commented Aug 14, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@highfive
Copy link

highfive commented Aug 14, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 14, 2015

Thank you for your PR!

-S-awaiting-review +S-needs-code-changes +S-needs-squash


Reviewed 1 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


components/script/dom/websocket.rs, line 52 [r4] (raw file):
Nit: ptr comes before sync


components/script/dom/websocket.rs, line 441 [r4] (raw file):
If data.len() is more than 2^32, this will overwrite unallocated memory. Please store data.len() as u32 in a local, and cast back to usize here.


Comments from the review on Reviewable.io

@Ms2ger Ms2ger self-assigned this Aug 14, 2015
@tomjakubowski tomjakubowski force-pushed the tomjakubowski:websocket-binaryType branch from aea3492 to 1f1dbfa Aug 14, 2015
@tomjakubowski
Copy link
Contributor Author

tomjakubowski commented Aug 14, 2015

@Ms2ger addressed your comments and squashed

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 15, 2015

Thank you!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2015

📌 Commit 1f1dbfa has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2015

Testing commit 1f1dbfa with merge 311dea8...

bors-servo pushed a commit that referenced this pull request Aug 15, 2015
Implement WebSocket#binaryType

Closes #7098

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2015

💔 Test failed - linux2

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 15, 2015

Looks like you missed one more:

/html/dom/interfaces.html
-------------------------
PASS expected FAIL WebSocket interface: attribute binaryType
@tomjakubowski tomjakubowski force-pushed the tomjakubowski:websocket-binaryType branch from 1f1dbfa to e92f462 Aug 15, 2015
@tomjakubowski
Copy link
Contributor Author

tomjakubowski commented Aug 15, 2015

Whoops. Re-pushed.

@jdm
Copy link
Member

jdm commented Aug 16, 2015

@bors-servo: r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2015

📌 Commit e92f462 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2015

Testing commit e92f462 with merge 7c63c7d...

bors-servo pushed a commit that referenced this pull request Aug 16, 2015
Implement WebSocket#binaryType

Closes #7098

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit e92f462 into servo:master Aug 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.