Implement setters in URLUtils

[nox]

This fixes #6145 and takes care of most of #4250.

[jdm]

@dzbarsky Would you like to review this?

[dzbarsky]

I'm gone for the next week, but I'll do it week after next if nobody else
gets to it.

On Sat, Aug 15, 2015, 10:29 AM Josh Matthews notifications@github.com
wrote:

@dzbarsky https://github.com/dzbarsky Would you like to review this?

—
Reply to this email directly or view it on GitHub
#7228 (comment).

[nox]

Cc'ing @SimonSapin.

[Ms2ger]

Reviewed 3 of 5 files at r1.
Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/location.rs, line 88 [r1] (raw file):}
This can't throw.

---

Comments from the review on Reviewable.io

[nox]

Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/location.rs, line 88 [r1] (raw file):}
https://url.spec.whatwg.org/#dom-urlutils-href

Setter, step 2, in the URL case it can throw.

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #7224) made this pull request unmergeable. Please resolve the merge conflicts.

[bors-servo]

☔ The latest upstream changes (presumably #7401) made this pull request unmergeable. Please resolve the merge conflicts.

[nox]

#7412

[bors-servo]

☔ The latest upstream changes (presumably #7416) made this pull request unmergeable. Please resolve the merge conflicts.

[jdm]

@bors-servo: r+

---

Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 2 files at r3, 1 of 1 files at r4.
Review status: 4 of 5 files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 9c4766b has been approved by jdm

[jdm]

Thanks for tackling this, @nox!

[bors-servo]

⌛ Testing commit 9c4766b with merge 347e9b6...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt