Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImproved field names for devtools-related channels... #7238
Conversation
|
@Ms2ger r? |
wafflespeanut
force-pushed the
wafflespeanut:workerglobal
branch
from
c96b5ae
to
8c685e8
|
|
||
| #[ignore_heap_size_of = "Defined in std"] | ||
| /// This `Receiver` will be ignored later if the corresponding | ||
| /// `IpcSender` doesn't exist | ||
| devtools_receiver: Receiver<DevtoolScriptControlMsg>, | ||
| devtools_client_script_process_receiver: Receiver<DevtoolScriptControlMsg>, |
This comment has been minimized.
This comment has been minimized.
Ms2ger
Aug 20, 2015
Contributor
Maybe using to_devtools_sender/from_devtools_sender/from_devtools_receiver would be better.
wafflespeanut
force-pushed the
wafflespeanut:workerglobal
branch
from
8c685e8
to
46195f2
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 20, 2015
Improved field names for devtools-related channels... (for #6924) - I took this because the confusion was actually caused by me while working on #6829 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7238) <!-- Reviewable:end -->
This was referenced Aug 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wafflespeanut commentedAug 15, 2015
(for #6924) - I took this because the confusion was actually caused by me while working on #6829