Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for input element's maxlength attr #7323

Merged
merged 14 commits into from Dec 3, 2015
+407 −202
Merged

Adds support for input element's maxlength attr #7323

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d26c555
Adds support for input element's maxlength attr
samfoo Aug 23, 2015
eecdfdf
Makes int_getter macro, and uses -1 as default maxlength instead of m…
samfoo Aug 31, 2015
419a26e
Adds a test for set_content to ignore max_length
samfoo Sep 1, 2015
2ba1750
Resolves long-running merge conflicts
samfoo Dec 1, 2015
5450d49
Removes failure expectations for input.maxLength WPT tests
samfoo Sep 13, 2015
ecc7035
Correct the default max length
samfoo Sep 13, 2015
32627a4
Add maxlength manual test for input
samfoo Sep 15, 2015
85b99f8
Fix typo in error message
samfoo Dec 2, 2015
6d1624f
Add additional WPT tests for maxlength parser set
samfoo Oct 2, 2015
51ca659
Add maxlength wpt to manifest
samfoo Oct 8, 2015
9668500
Makes setting negative values to maxLength throw an IndexSize exception
samfoo Dec 2, 2015
7ba4391
Uses `assert_throws` instead of explicit try/catch
samfoo Dec 2, 2015
d375ac2
Fix manifest update
samfoo Dec 2, 2015
4befd2c
Fixes typo in test literal
samfoo Dec 3, 2015
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev Next

Removes failure expectations for input.maxLength WPT tests

  • Loading branch information
@samfoo
samfoo committed Dec 3, 2015
commit 5450d49f5782edc941f925cb803255366529171e
6 tests/wpt/metadata/html/dom/interfaces.html.ini
View file
Open in desktop
@@ -4860,9 +4860,6 @@
[HTMLInputElement interface: attribute max]
expected: FAIL

[HTMLInputElement interface: attribute maxLength]
expected: FAIL

[HTMLInputElement interface: attribute min]
expected: FAIL

@@ -4983,9 +4980,6 @@
[HTMLInputElement interface: document.createElement("input") must inherit property "max" with the proper type (19)]
expected: FAIL

[HTMLInputElement interface: document.createElement("input") must inherit property "maxLength" with the proper type (20)]
expected: FAIL

[HTMLInputElement interface: document.createElement("input") must inherit property "min" with the proper type (21)]
expected: FAIL

183 tests/wpt/metadata/html/dom/reflection-forms.html.ini
View file
Open in desktop
@@ -4977,189 +4977,6 @@
[input.max: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL

[input.maxLength: typeof IDL attribute]
expected: FAIL

[input.maxLength: IDL get with DOM attribute unset]
expected: FAIL

[input.maxLength: setAttribute() to -2147483649 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to -2147483648 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to -36 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to -1 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to -0 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 0 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 1 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 2147483647 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 2147483648 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 4294967295 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 4294967296 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "-1" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "-0" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "0" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "1" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\t7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\v7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\f7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\n7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\r7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "
7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "
7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "᠎7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to " 7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "　7" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to undefined followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to 1.5 followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to true followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to false followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to NaN followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to Infinity followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to -Infinity followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to "\\0" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to object "2" followed by IDL get]
expected: FAIL

[input.maxLength: setAttribute() to object "3" followed by IDL get]
expected: FAIL

[input.maxLength: IDL set to -2147483648 must throw INDEX_SIZE_ERR]
expected: FAIL

[input.maxLength: IDL set to -36 must throw INDEX_SIZE_ERR]
expected: FAIL

[input.maxLength: IDL set to -1 must throw INDEX_SIZE_ERR]
expected: FAIL

[input.maxLength: IDL set to 0 followed by getAttribute()]
expected: FAIL

[input.maxLength: IDL set to 1 followed by getAttribute()]
expected: FAIL

[input.maxLength: IDL set to 2147483647 followed by getAttribute()]
expected: FAIL

[input.min: typeof IDL attribute]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.