Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of inheritance in type ids #7337

Merged
merged 1 commit into from Sep 5, 2015

Conversation

@wilcus
Copy link
Contributor

wilcus commented Aug 24, 2015

Aditional documentation about this issue #7205

Review on Reviewable

@wilcus wilcus force-pushed the wilcus:InheritanceDocumentation branch 2 times, most recently from c926a11 to 452bc40 Aug 25, 2015
@mbrubeck mbrubeck self-assigned this Aug 31, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 31, 2015

Looks good, thanks! See below for some minor proof-reading.

-S-awaiting-review +S-needs-code-changes


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


components/script/dom/mod.rs, line 57 [r1] (raw file):
"apply" should be "applies"


components/script/dom/mod.rs, line 57 [r1] (raw file):
There should be a period or colon after "typeids," and the following "the" should start a new sentence.


components/script/dom/mod.rs, line 58 [r1] (raw file):
typo: "additional"


Comments from the review on Reviewable.io

@wilcus wilcus force-pushed the wilcus:InheritanceDocumentation branch from 452bc40 to 1830ada Sep 2, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 4, 2015

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

📌 Commit 1830ada has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2015

Testing commit 1830ada with merge 1b01479...

bors-servo pushed a commit that referenced this pull request Sep 5, 2015
Documentation of inheritance in type ids

Aditional documentation about this issue #7205

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7337)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2015

💔 Test failed - mac-rel-wpt

@jdm
Copy link
Member

jdm commented Sep 5, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2015

Testing commit 1830ada with merge da0b9d7...

bors-servo pushed a commit that referenced this pull request Sep 5, 2015
Documentation of inheritance in type ids

Aditional documentation about this issue #7205

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7337)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2015

@bors-servo bors-servo merged commit 1830ada into servo:master Sep 5, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.