Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handle_potential_webgl_error more ergonomic #7360

Merged
merged 1 commit into from Aug 26, 2015
Merged

Make handle_potential_webgl_error more ergonomic #7360

merged 1 commit into from Aug 26, 2015
+8 −5

Conversation

@wilcus
Copy link
Contributor

wilcus commented Aug 25, 2015

#7358

Review on Reviewable
@jdm
Copy link
Member

jdm commented Aug 25, 2015

Can you update the existing case where we use this macro with (), too?
@wilcus
Copy link
Contributor Author

wilcus commented Aug 25, 2015

Yes, i'll search that
@wilcus wilcus force-pushed the wilcus:ErgonomicSignature branch from 29a7496 to 3d6d2a8 Aug 25, 2015
@wilcus
Copy link
Contributor Author

wilcus commented Aug 25, 2015

I've finished now
@jdm
Copy link
Member

jdm commented Aug 25, 2015

As it happens, #6770 added several additional uses, too. Could you rebase and update those?
@wilcus
Copy link
Contributor Author

wilcus commented Aug 25, 2015

ok, i forget to pull
@wilcus
Make handle_potential_webgl_error more ergonomic
Loading status checks…
363183d
@wilcus wilcus force-pushed the wilcus:ErgonomicSignature branch from 3d6d2a8 to 363183d Aug 25, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 26, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2015

📌 Commit 363183d has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2015

⌛ Testing commit 363183d with merge 06ba216...
bors-servo pushed a commit that referenced this pull request Aug 26, 2015
bors-servo
Auto merge of #7360 - wilmoz:ErgonomicSignature, r=Ms2ger
Loading status checks…
06ba216 
Make handle_potential_webgl_error more ergonomic

#7358

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7360)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3
@bors-servo bors-servo mentioned this pull request Aug 26, 2015
Closed
@bors-servo bors-servo merged commit 363183d into servo:master Aug 26, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@wilcus @jdm @Ms2ger @bors-servo @highfive
You can’t perform that action at this time.