Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for flexbox crasher #7388

Merged
merged 1 commit into from Sep 8, 2015
Merged

Test for flexbox crasher #7388

merged 1 commit into from Sep 8, 2015
+73 −0

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 26, 2015

Closes #7332

Review on Reviewable
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 26, 2015

This test will still pass without the crasher fix (#7388) because we don't run the tests with the -e flag.

Can we still land this? Or should we still try to find a solution for #7335? Or we just don't write test for experimental features?
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 26, 2015

/cc @jgraham
@jdm
Copy link
Member

jdm commented Aug 30, 2015

Once we get an update of wptrunner that includes w3c/wptrunner#141 this can land with changes like jdm@447b5b5 .
@metajack metajack self-assigned this Sep 1, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 4, 2015

@paulrouget prefs work now: https://github.com/jdm/servo/blob/cssprefs3/tests/wpt/metadata-css/css-flexbox-1_dev/__dir__.ini
@paulrouget
Test for flexbox crasher
Loading status checks…
f6582e7
@paulrouget paulrouget force-pushed the paulrouget:issue-7332 branch from 7b76024 to f6582e7 Sep 7, 2015
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 7, 2015

Took me for ever to understand that the __dir__.ini should go into the meta directory, not directly in the test directory.
@metajack
Copy link
Contributor

metajack commented Sep 8, 2015

@bors-servo r+

Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2015

📌 Commit f6582e7 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2015

⌛ Testing commit f6582e7 with merge 68f32f7...
bors-servo pushed a commit that referenced this pull request Sep 8, 2015
bors-servo
Auto merge of #7388 - paulrouget:issue-7332, r=metajack
Loading status checks…
68f32f7 
Test for flexbox crasher

Closes #7332

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7388)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f6582e7 into servo:master Sep 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@paulrouget @jdm @Ms2ger @metajack @bors-servo @highfive
You can’t perform that action at this time.