Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for flexbox crasher #7388

Merged
merged 1 commit into from
Sep 8, 2015
Merged

Test for flexbox crasher #7388

merged 1 commit into from
Sep 8, 2015

Conversation

paulrouget
Copy link
Contributor

Closes #7332

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 26, 2015
@paulrouget
Copy link
Contributor Author

This test will still pass without the crasher fix (#7388) because we don't run the tests with the -e flag.

Can we still land this? Or should we still try to find a solution for #7335? Or we just don't write test for experimental features?

@paulrouget
Copy link
Contributor Author

/cc @jgraham

@jdm
Copy link
Member

jdm commented Aug 30, 2015

Once we get an update of wptrunner that includes w3c/wptrunner#141 this can land with changes like jdm@447b5b5 .

@jdm jdm added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 30, 2015
@metajack metajack self-assigned this Sep 1, 2015
@Ms2ger Ms2ger added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. labels Sep 4, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 4, 2015

@paulrouget prefs work now: https://github.com/jdm/servo/blob/cssprefs3/tests/wpt/metadata-css/css-flexbox-1_dev/__dir__.ini

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Sep 7, 2015
@paulrouget
Copy link
Contributor Author

Took me for ever to understand that the __dir__.ini should go into the meta directory, not directly in the test directory.

@metajack
Copy link
Contributor

metajack commented Sep 8, 2015

@bors-servo r+

Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

📌 Commit f6582e7 has been approved by metajack

@bors-servo
Copy link
Contributor

⌛ Testing commit f6582e7 with merge 68f32f7...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 8, 2015
bors-servo pushed a commit that referenced this pull request Sep 8, 2015
Auto merge of #7388 - paulrouget:issue-7332, r=metajack
68f32f7 
Test for flexbox crasher

Closes #7332

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7388)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit f6582e7 into servo:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paulrouget @jdm @Ms2ger @metajack @bors-servo @highfive