Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requestAnimationFrame in headless mode. Fixes #7296. #7417

Merged
merged 1 commit into from Aug 28, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix requestAnimationFrame in headless mode. Fixes #7296.

  • Loading branch information
gw3583 committed Aug 27, 2015
commit 103feca08bf368935a1854afd6a09082e1f79277
@@ -7,6 +7,7 @@ use windowing::WindowEvent;

use euclid::scale_factor::ScaleFactor;
use euclid::size::Size2D;
use msg::constellation_msg::AnimationState;
use msg::constellation_msg::Msg as ConstellationMsg;
use msg::constellation_msg::{ConstellationChan, WindowSizeData};
use profile_traits::mem;
@@ -88,14 +89,25 @@ impl CompositorEventListener for NullCompositor {
response_chan.send(()).unwrap();
}

Msg::ChangeRunningAnimationsState(pipeline_id, animation_state) => {
match animation_state {
AnimationState::AnimationsPresent |
AnimationState::NoAnimationsPresent |
AnimationState::NoAnimationCallbacksPresent => {}
AnimationState::AnimationCallbacksPresent => {
let msg = ConstellationMsg::TickAnimation(pipeline_id);
self.constellation_chan.0.send(msg).unwrap()
}
}
}

// Explicitly list ignored messages so that when we add a new one,
// we'll notice and think about whether it needs a response, like
// SetFrameTree.

Msg::InitializeLayersForPipeline(..) |
Msg::SetLayerRect(..) |
Msg::AssignPaintedBuffers(..) |
Msg::ChangeRunningAnimationsState(..) |
Msg::ScrollFragmentPoint(..) |
Msg::Status(..) |
Msg::LoadStart(..) |

This file was deleted.

@@ -8,8 +8,6 @@
<script>
async_test(function() {
window.requestAnimationFrame(this.step_func_done());
// FIXME(#7296)
setTimeout(this.step_func_done(), 500);
});
</script>
</body>
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.