Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow some warnings in codegen anymore #7455

Merged
merged 5 commits into from Aug 30, 2015
Merged

Do not allow some warnings in codegen anymore #7455

merged 5 commits into from Aug 30, 2015

Conversation

@nox
Copy link
Member

nox commented Aug 30, 2015

This fixes #395.

Review on Reviewable
nox added 5 commits Aug 30, 2015
@nox
Do not allow unused_unsafe in codegen anymore
aaa7a86
@nox
Do not allow unused_mut in codegen anymore
1064e7d
@nox
Do not allow unused_parens in codegen anymore
2c8638e
@nox
Do not allow dead_code in codegen anymore
3c1c315
@nox
Do not allow unreachable_code in codegen anymore
Loading status checks…
cf6975f
@highfive
Copy link

highfive commented Aug 30, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox nox mentioned this pull request Aug 30, 2015
Open
@jdm
Copy link
Member

jdm commented Aug 30, 2015

@bors-servo: r+
This is great!
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2015

📌 Commit cf6975f has been approved by jdm
@nox nox assigned jdm Aug 30, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2015

⌛ Testing commit cf6975f with merge a855669...
bors-servo pushed a commit that referenced this pull request Aug 30, 2015
bors-servo
Auto merge of #7455 - nox:rm-unused-warnings, r=jdm
Loading status checks…
a855669 
Do not allow some warnings in codegen anymore

This fixes #395.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7455)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member

frewsxcv commented Aug 30, 2015

Nice! 🎊
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit cf6975f into servo:master Aug 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:rm-unused-warnings branch Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

codegen should use unsafe blocks correctly
5 participants
@nox @highfive @jdm @bors-servo @frewsxcv
You can’t perform that action at this time.