Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement obsolete IDL attributes for <font> element #7472

Closed
wants to merge 1 commit into from

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Aug 31, 2015

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 31, 2015

Out of curiosity, why'd you pick those in particular?

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 31, 2015

I don't remember why I picked this set of attributes. If implementing these obsolete IDL attributes is desired, I'm open to closing this and just opening a new one that implements a bunch all at once

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 31, 2015

No, this is fine, just curious.

@nox
Copy link
Member

nox commented Aug 31, 2015

It's fine to implement missing IDL attributes, but I'm not too sure about doing that without implementing what they actually do, like the color attribute. See HTMLFontElement::get_color() and Element::synthesize_presentational_hints_for_legacy_attributes().

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 31, 2015

Sounds good. I'll implement those, but to avoid conflicts, going to wait a day or so to see if #7452 merges

@nox
Copy link
Member

nox commented Aug 31, 2015

@frewsxcv Thanks. :)

@metajack
Copy link
Contributor

metajack commented Sep 1, 2015

r? @Ms2ger

@nox nox assigned nox and unassigned Ms2ger Sep 1, 2015
@nox
Copy link
Member

nox commented Sep 1, 2015

Stealing review since I commented.

@nox
Copy link
Member

nox commented Sep 1, 2015

@metajack This is blocked on #7452, to avoid unnecessary rebases.

@nox
Copy link
Member

nox commented Sep 7, 2015

@frewsxcv #7452 landed.

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 7, 2015

Alright cool. I'm on traveling for a few more days, then I'll look into this

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 11, 2015

I'm just going to close this for now. I haven't gotten around to updating this so no point in keeping it around

@frewsxcv frewsxcv closed this Sep 11, 2015
@frewsxcv frewsxcv deleted the frewsxcv:obsolete-font-idl-attributes branch Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.