Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement obsolete IDL attributes for <font> element #7472
Conversation
|
If this is desire and gets approved, I'll go ahead and implement the rest https://github.com/servo/servo/blob/master/tests/wpt/metadata/html/dom/reflection-obsolete.html.ini |
|
Out of curiosity, why'd you pick those in particular? |
|
I don't remember why I picked this set of attributes. If implementing these obsolete IDL attributes is desired, I'm open to closing this and just opening a new one that implements a bunch all at once |
|
No, this is fine, just curious. |
|
It's fine to implement missing IDL attributes, but I'm not too sure about doing that without implementing what they actually do, like the color attribute. See HTMLFontElement::get_color() and Element::synthesize_presentational_hints_for_legacy_attributes(). |
|
Sounds good. I'll implement those, but to avoid conflicts, going to wait a day or so to see if #7452 merges |
|
@frewsxcv Thanks. :) |
|
r? @Ms2ger |
|
Stealing review since I commented. |
|
Alright cool. I'm on traveling for a few more days, then I'll look into this |
|
I'm just going to close this for now. I haven't gotten around to updating this so no point in keeping it around |
frewsxcv commentedAug 31, 2015