Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake AttrVal tokens() and atom() return or panic #7511
Merged
Conversation
|
Please rename to as_atoms and as_tokens. |
|
r? @nox |
|
|
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 2, 2015
make AttrVal tokens() and atom() return or panic Fixes #7479 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7511) <!-- Reviewable:end -->
|
|
| @@ -69,7 +69,7 @@ impl DOMTokenListMethods for DOMTokenList { | |||
| fn Item(&self, index: u32) -> Option<DOMString> { | |||
| self.attribute().and_then(|attr| { | |||
| let attr = attr.r(); | |||
| attr.value().tokens().and_then(|tokens| { | |||
| Some(attr.value().as_tokens()).and_then(|tokens| { | |||
This comment has been minimized.
This comment has been minimized.
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Sep 2, 2015
make AttrVal tokens() and atom() return or panic Fixes #7479 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7511) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
psdh commentedSep 2, 2015
Fixes #7479