Implement <template>

[nox]

All tests using iframes can't currently pass, same for innerHTML-related tests with elements. The latter contradicts the spec, see the links below.

Apart from this, they work, AFAICT.

servo/html5ever#164
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27314

[nox]

Cc @Manishearth

[nox]

I fixed the innerHTML bugs following w3c/DOM-Parsing#1.

[nox]

r? @jdm

[Ms2ger]

Reviewed 2 of 2 files at r1, 19 of 19 files at r2, 15 of 15 files at r3, 9 of 12 files at r4.
Review status: 23 of 26 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmltemplateelement.rs, line 57 [r3] (raw file):}
I think this is wrong. Consider

var doc1, doc2;
var templateA = doc1.createElement("template");
var templateB = doc1.createElement("template");
doc2.adoptNode(templateA)
assert_equals(templateA.content.ownerDocument, templateB.content.ownerDocument);

and I suspect there's a bug with the temporary document used for fragment parsing too.

Oh, hm, the spec handles this.

---

^{components/script/dom/htmltemplateelement.rs, line 72 [r4] (raw file):}
Link to ttps://html.spec.whatwg.org/multipage/#template-adopting-steps (which will be added momentarily).

---

^{components/script/dom/node.rs, line 1426 [r1] (raw file):}
It's really scary to have unsuspecting code running while nodes in the same tree have different node documents.

---

Comments from the review on Reviewable.io

[nox]

@Ms2ger I put back the merged loops in Node::adopt(), because that's how I specified how adopting steps should be run in whatwg/dom#66. If you really want me to split them, and I don't think it's necessary given there is only one use of them in HTML for template, I would like the spec to be changed to two loops first.

[Ms2ger]

I do really want you to split them.

[nox]

@Ms2ger Done and reported upstream. whatwg/dom#71

[nox]

@Ms2ger I find that quite pointless though, bind_to_tree and unbind_to_tree do the exact same thing.

[Ms2ger]

You didn't split them.

-S-awaiting-review +S-needs-code-changes

---

Reviewed 3 of 12 files at r4, 3 of 3 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 43975bd has been approved by Ms2ger

[bors-servo]

⌛ Testing commit 43975bd with merge 1537c45...

[bors-servo]

💔 Test failed - linux-rel

[nox]

@bors-servo r=Ms2ger

Fixed test expectations.

[bors-servo]

📌 Commit b382004 has been approved by Ms2ger

[bors-servo]

⌛ Testing commit b382004 with merge 5a0be12...

[bors-servo]

💔 Test failed - mac-rel-wpt

[nox]

@bors-servo retry

#7422

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt