Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: change requestAnimationFrame returns the unsigned long type. #7538

Merged
merged 1 commit into from Sep 4, 2015

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Sep 4, 2015

By whatwg/html#97, the returned type ofrequestAnimationFrame() and the argument type of cancelAnimationFrame() are changed to unsigned long WebIDL type.

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

📌 Commit 6362740 has been approved by Ms2ger

@Ms2ger Ms2ger self-assigned this Sep 4, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

Testing commit 6362740 with merge 43e7cd5...

bors-servo pushed a commit that referenced this pull request Sep 4, 2015
script: change requestAnimationFrame returns the unsigned long type.

By whatwg/html#97, the returned type of`requestAnimationFrame()` and the argument type of `cancelAnimationFrame()` are changed to `unsigned long` WebIDL type.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

💔 Test failed - mac-rel-wpt

@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Sep 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2015

@bors-servo bors-servo merged commit 6362740 into servo:master Sep 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:requestAnimationFrame branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.