Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate prefs API to return an Option<bool>. #7545
Merged
+12
−12
Conversation
This allows for situations where there is no reasonable default to apply for the pref value e.g. when we are just listing values
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 4, 2015
Update prefs API to return an Option<bool>. This allows for situations where there is no reasonable default to apply for the pref value e.g. when we are just listing values <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7545) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jgraham commentedSep 4, 2015
This allows for situations where there is no reasonable default
to apply for the pref value e.g. when we are just listing values