Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd get/set pref extensions to webdriver server. #7548
Conversation
|
Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed. components/webdriver_server/lib.rs, line 85 [r1] (raw file): components/webdriver_server/lib.rs, line 158 [r1] (raw file): components/webdriver_server/lib.rs, line 165 [r1] (raw file): components/webdriver_server/lib.rs, line 634 [r1] (raw file): let prefs = parameters.prefs
.iter()
.map(|item| (item.clone(), get_pref(item).to_json()))
.collect::<BTreeMap<_>>();Comments from the review on Reviewable.io |
This can be used by the test framework to ensure that the correct prefs are set for a test without restarting the browser
|
Shouldn't there be a third Cargo.lock update or does webdriver_server not get used on Android? Otherwise looks good. Reviewed 4 of 4 files at r1. Comments from the review on Reviewable.io |
|
It's an optional cargo feature that doesn't get enabled on android right now, presumably. |
|
I don't know, I just trusted |mach cargo-update| |
|
@bors-servo r+ |
|
|
Add get/set pref extensions to webdriver server. This can be used by the test framework to ensure that the correct prefs are set for a test without restarting the browser <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7548) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Add get/set pref extensions to webdriver server. This can be used by the test framework to ensure that the correct prefs are set for a test without restarting the browser <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7548) <!-- Reviewable:end -->
|
|
jgraham commentedSep 4, 2015
This can be used by the test framework to ensure that the correct prefs are
set for a test without restarting the browser