Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/set pref extensions to webdriver server. #7548

Merged
merged 1 commit into from Sep 15, 2015

Conversation

@jgraham
Copy link
Contributor

jgraham commented Sep 4, 2015

This can be used by the test framework to ensure that the correct prefs are
set for a test without restarting the browser

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 7, 2015

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


components/webdriver_server/lib.rs, line 85 [r1] (raw file):
Too long


components/webdriver_server/lib.rs, line 158 [r1] (raw file):
Nested try is very hard to read.


components/webdriver_server/lib.rs, line 165 [r1] (raw file):
(x, y)


components/webdriver_server/lib.rs, line 634 [r1] (raw file):
Better as

let prefs = parameters.prefs
                      .iter()
                      .map(|item| (item.clone(), get_pref(item).to_json()))
                      .collect::<BTreeMap<_>>();

Comments from the review on Reviewable.io

This can be used by the test framework to ensure that the correct prefs are
set for a test without restarting the browser
@jgraham jgraham force-pushed the jgraham:webdriver_prefs branch from 7a8b951 to e0a7b2b Sep 8, 2015
@Ms2ger Ms2ger removed their assignment Sep 11, 2015
@jgraham jgraham removed the S-fails-tidy label Sep 11, 2015
@metajack
Copy link
Contributor

metajack commented Sep 14, 2015

Shouldn't there be a third Cargo.lock update or does webdriver_server not get used on Android?

Otherwise looks good.


Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@metajack metajack self-assigned this Sep 14, 2015
@jdm
Copy link
Member

jdm commented Sep 14, 2015

It's an optional cargo feature that doesn't get enabled on android right now, presumably.

@jgraham
Copy link
Contributor Author

jgraham commented Sep 14, 2015

I don't know, I just trusted |mach cargo-update|

@metajack
Copy link
Contributor

metajack commented Sep 14, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

📌 Commit e0a7b2b has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

Testing commit e0a7b2b with merge 6703e9e...

bors-servo pushed a commit that referenced this pull request Sep 14, 2015
Add get/set pref extensions to webdriver server.

This can be used by the test framework to ensure that the correct prefs are
set for a test without restarting the browser

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7548)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Sep 15, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

Testing commit e0a7b2b with merge 67cf241...

bors-servo pushed a commit that referenced this pull request Sep 15, 2015
Add get/set pref extensions to webdriver server.

This can be used by the test framework to ensure that the correct prefs are
set for a test without restarting the browser

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7548)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

@bors-servo bors-servo merged commit e0a7b2b into servo:master Sep 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.