Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Defend the block formatting context speculation against going wrong in the presence of blocks that overflow in the inline direction. #7550

Merged
merged 1 commit into from Sep 11, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Sep 5, 2015

Makes the Google search result links appear.

Closes #7298.

r? @mbrubeck

Review on Reviewable

… wrong in

the presence of blocks that overflow in the inline direction.

Makes the Google search result links appear.

Closes #7298.
@mbrubeck mbrubeck self-assigned this Sep 5, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 11, 2015

Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 11, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2015

📌 Commit ded4a57 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2015

Testing commit ded4a57 with merge c3f9e18...

bors-servo pushed a commit that referenced this pull request Sep 11, 2015
…brubeck

layout: Defend the block formatting context speculation against going wrong in the presence of blocks that overflow in the inline direction.

Makes the Google search result links appear.

Closes #7298.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7550)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2015

💔 Test failed - mac-rel-wpt

@jdm
Copy link
Member

jdm commented Sep 11, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2015

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2015

@bors-servo bors-servo merged commit ded4a57 into servo:master Sep 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.