Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle cases where the layout root is None. Fixes #6375. #7557
Conversation
|
Yeah, this has come up again and again and I agree that being defensive is the right approach here. I'll look in depth at this patch in an hour or so. |
| @@ -2963,7 +2963,7 @@ impl ISizeAndMarginsComputer for InlineBlockReplaced { | |||
| MaybeAuto::Auto => false, | |||
| }); | |||
|
|
|||
| let (mut computed_inline_size, | |||
| let (computed_inline_size, | |||
This comment has been minimized.
This comment has been minimized.
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 8, 2015
Handle cases where the layout root is None. Fixes #6375. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7557) <!-- Reviewable:end -->
|
|
|
|
@bors-servo retry |
|
For future reference, #6312 is a much better tracking issue for that intermittent failure. |
bors-servo
pushed a commit
that referenced
this pull request
Sep 9, 2015
Handle cases where the layout root is None. Fixes #6375. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7557) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 8, 2015